Fix MimeMessage::extract_uue() ignoring index greater than zero#68
Closed
iliaal wants to merge 1 commit into
Closed
Fix MimeMessage::extract_uue() ignoring index greater than zero#68iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #73, reopened from the fork (iliaal/pecl-mail-mailparse). Branch should not have been pushed to php/ directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MimeMessage::extract_uue($index, ...)returns NULL for any$index >= 1, so only the first uuencoded attachment in a message is reachable.The method compares a part counter
npartsagainst$indexbut never increments it, unlike the siblingenum_uuewhich does. Sonparts == indexonly ever matches index 0.Fix
Increment
npartsafter skipping a non-matching part, so the counter advances to the requested index.